[coreboot-gerrit] Change in coreboot[master]: [TESTME] sb/amd/pi/hudson/early_init: fix setting SPI_USE_SPI100 in S...

[Felix Held (Code Review)]

Attention is currently required from: Michał Żygowski, Michał Kopeć.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59934 )

Change subject: [TESTME] sb/amd/pi/hudson/early_init: fix setting SPI_USE_SPI100 in SPI100_ENABLE
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> SPIx20 register in BKDG describes only the bit0 (SPI100_ENABLE), the rest is reserved. […]

especially bits 8-11 of SPIx20 which are the same bits as bits 0-3 of SPIx21 shouldn't be cleared. I don't think that it make much of a difference for bits 1-7 of SPIx20; those are either reserved or default 0 on Mullins.
I just noticed that this function is unused; shouldn't hurt to fix this there too though