[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/brox: Fix booting to kernel without battery

[Subrata Banik (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Jayvik Desai, Karthik Ramasubramanian, Keith Short, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Rishika Raj, Ronak Kanabar, Shelley Chen, Sowmya Aralguppe, Sowmya Aralguppe.

Subrata Banik has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )

Change subject: mb/google/brox: Fix booting to kernel without battery
......................................................................

Patch Set 26:

(3 comments)

File src/mainboard/google/brox/Kconfig:

https://review.coreboot.org/c/coreboot/+/83752/comment/809e2f20_0e02e75f?usp... :
PS26, Line 122:  if BOARD_GOOGLE_BASEBOARD_BROX
u don't need this as code is inside brox and there is no other baseboard

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/2fefe3eb_0c40e82d?usp... :
PS26, Line 75: 		printk(BIOS_INFO, "Battery is not present or disconnected\n");
both print msg seems redundant looking at line 103

you can drop both imo

https://review.coreboot.org/c/coreboot/+/83752/comment/a60e17e2_ed8ba3fb?usp... :
PS26, Line 77: 	printk(BIOS_INFO, "CPU PL4 is %u\n", soc_config->tdp_pl4);
we have same msg in line 104