Attention is currently required from: Rory Liu, Tim Wawrzynczak, Zhuohao Lee.
Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/0adcff52_05282013
PS3, Line 359: /* Enable ASPM_L1.2 */
: if (CONFIG(PCIEXP_ASPM))
: enable_aspm_l1_2(io_base);
Is this applicable to both the 8168 and 8125 ?
Basically, yes. The solutions will also work for 8168. However for example the project Puff, which has set the "stop_gpio" in devicetree, we have to remove that code first or this solution would fail. If we cannot do that, the previous patchset which using "enable_aspm=1" in devicetree would be better?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 3
Gerrit-Owner: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 03:40:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment