Johanna Schander has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@10 PS15, Line 10: setup
The verb is spelled with a space: set up. […]
Done
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@15 PS15, Line 15: For the moment the bootsplash is still limited to VGA-OptionROM framebuffer init.
Just for my memory, what happens if the bootsplash image has different dimensions? Is it cropped or […]
Old requirement: framebuffer >= image == 1024x768@16 New requirement: image == framebuffer
Else it would have overflown the FB.
I would like to add the code to center the image in the FB later, so that it can be used to display independent of the resolution
https://review.coreboot.org/c/coreboot/+/34537/15//COMMIT_MSG@16 PS15, Line 16:
Please document how you tested this.
parially Done. vgabios tested on razer blade stealth no clue how to test yabel tbh :/
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/oprom/realmode/... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/15/src/device/oprom/realmode/... PS15, Line 354:
For the future, please do clean-ups in separate commits.
Okay. Thanks :)
https://review.coreboot.org/c/coreboot/+/34537/15/src/lib/bootsplash.h File src/lib/bootsplash.h:
https://review.coreboot.org/c/coreboot/+/34537/15/src/lib/bootsplash.h@20 PS15, Line 20: * Returns 0 on success
The return type is void currently. […]
Yes. My thought: It is not a critical part boot-up and does its own logging. Also there is no expected behaviour if something goes wrong. There is not really a way to recover.