Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32725 )
Change subject: Replace ENV_RAMSTAGE with ENV_PAYLOAD_LOADER ......................................................................
Patch Set 4:
(7 comments)
It looks like you have replaced all occurrences of ENV_RAMSTAGE with ENV_PAYLOAD_LOADER. But, is the intent to really enable all the different blocks for postcar when it is the payload loader? e.g. pci drivers? microcode loader? others? How is the ramstage different than postcar in that case?
https://review.coreboot.org/#/c/32725/4/src/arch/x86/exception.c File src/arch/x86/exception.c:
PS4: Is there a plan to enable this for postcar? Sorry, I am not very clear at this point what all blocks postcar would include from ramstage.
https://review.coreboot.org/#/c/32725/4/src/arch/x86/exception.c@597 PS4, Line 597: /* This global is for src/cpu/x86/lapic/secondary.S usage which is only : used during ramstage. */ Same question as the file comment. Do you plan to do this for postcar?
https://review.coreboot.org/#/c/32725/4/src/console/console.c File src/console/console.c:
https://review.coreboot.org/#/c/32725/4/src/console/console.c@82 PS4, Line 82: GDB_STUB Do you plan to enable GDB stub for postcar too?
https://review.coreboot.org/#/c/32725/4/src/cpu/intel/microcode/microcode.c File src/cpu/intel/microcode/microcode.c:
PS4: Is there a plan to enable this for postcar?
https://review.coreboot.org/#/c/32725/4/src/drivers/net/ne2k.c File src/drivers/net/ne2k.c:
https://review.coreboot.org/#/c/32725/4/src/drivers/net/ne2k.c@323 PS4, Line 323: device_operations I thought you were planning to skip pci resource allocation for postcar? Is that not correct?
https://review.coreboot.org/#/c/32725/4/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/#/c/32725/4/src/lib/program.ld@58 PS4, Line 58: ENV_PAYLOAD_LOADER All the pci drivers are included in postcar?
https://review.coreboot.org/#/c/32725/4/src/mainboard/google/fizz/chromeos.c File src/mainboard/google/fizz/chromeos.c:
PS4: Do we really need to change all mainboards even if they won't enable loading from postcar?