[coreboot-gerrit] Change in coreboot[master]: cpu/x86/lapic: Drop parallel_cpu_init inside LEGACY_CPU_INIT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55204 )

Change subject: cpu/x86/lapic: Drop parallel_cpu_init inside LEGACY_CPU_INIT
......................................................................

cpu/x86/lapic: Drop parallel_cpu_init inside LEGACY_CPU_INIT

It was not used, platforms should move away from LEGACY_CPU_INIT
instead of maintaining this.

Change-Id: Id89ec4bb0bdc056ac328f31397e4fab02742e444
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/x86/lapic/lapic_cpu_init.c
1 file changed, 4 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/55204/1

diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c
index 1c1c15d..ab38025 100644
--- a/src/cpu/x86/lapic/lapic_cpu_init.c
+++ b/src/cpu/x86/lapic/lapic_cpu_init.c
@@ -20,8 +20,6 @@
 #include <stdlib.h>
 #include <thread.h>

-const int parallel_cpu_init = false;
-
 /* This is a lot more paranoid now, since Linux can NOT handle
  * being told there is a CPU when none exists. So any errors
  * will return 0, meaning no CPU.
@@ -289,8 +287,7 @@
 {
    atomic_inc(&active_cpus);

-	if (!parallel_cpu_init)
-		spin_lock(&start_cpu_lock);
+	spin_lock(&start_cpu_lock);

#ifdef __SSE3__
    /*
@@ -304,8 +301,7 @@
 #endif
    cpu_initialize(index);

-	if (!parallel_cpu_init)
-		spin_unlock(&start_cpu_lock);
+	spin_unlock(&start_cpu_lock);

atomic_dec(&active_cpus);

@@ -321,9 +317,6 @@
    	if (cpu->path.type != DEVICE_PATH_APIC)
    		continue;

-		if (parallel_cpu_init && (cpu == bsp_cpu))
-			continue;
-
    	if (!cpu->enabled)
    		continue;

@@ -335,8 +328,7 @@
    		printk(BIOS_ERR, "CPU 0x%02x would not start!\n",
    			cpu->path.apic.apic_id);

-		if (!parallel_cpu_init)
-			udelay(10);
+		udelay(10);
    }

}
@@ -439,14 +431,10 @@
    if (!CONFIG(SERIALIZED_SMM_INITIALIZATION))
    	smm_init();

-	/* start all aps at first, so we can init ECC all together */
-	if (is_smp_boot() && parallel_cpu_init)
-		start_other_cpus(cpu_bus, info->cpu);
-
    /* Initialize the bootstrap processor */
    cpu_initialize(0);

-	if (is_smp_boot() && !parallel_cpu_init)
+	if (is_smp_boot())
    	start_other_cpus(cpu_bus, info->cpu);

/* Now wait the rest of the cpus stop*/