[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: update dcxo output buffer setting

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32323 )

Change subject: mediatek/mt8183: update dcxo output buffer setting
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32323/4/src/soc/mediatek/mt8183/rtc.c 
File src/soc/mediatek/mt8183/rtc.c:

https://review.coreboot.org/#/c/32323/4/src/soc/mediatek/mt8183/rtc.c@285 
PS4, Line 285: 	rtc_write(PMIC_RG_DCXO_CW00, 0x4005);
It would be nicer if you had named constants for every bit here and would OR them together individually