Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38247 )
Change subject: soc/intel/common/cse: Add consistent HECI command id/group id naming ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38247/1/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38247/1/src/soc/intel/common/block/... PS1, Line 70: /* MKHI Command groups */ : #define MKHI_GROUP_ID_CBM 0x0 : #define MKHI_GROUP_ID_HMRFPO 0x5 : : /* Global Reset Command ID */ : #define MKHI_GLOBAL_RESET_REQ 0xb : : /* RST Origin */ : #define GR_ORIGIN_BIOS_POST 0x2 : : /* HMRFPO Command Ids */ : #define MKHI_HMRFPO_ENABLE 0x1 : #define MKHI_HMRFPO_GET_STATUS 0x3 : : /* ME Current Working States */ : #define ME_HFS1_CWS_NORMAL 0x5 : : /* ME Current Operation Modes */ : #define ME_HFS1_COM_NORMAL 0x0 : #define ME_HFS1_COM_SOFT_TEMP_DISABLE 0x3 : #define ME_HFS1_COM_SECOVER_MEI_MSG 0x5
Done
Done
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 23:
Done
Done
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 164: /* Command GLOBAL_RESET_REQ Reset Types */ : #define GLOBAL_RESET 1 : #define HOST_RESET_ONLY 2 : #define CSE_RESET_ONLY 3
nit: This should probably be moved up under MKHI_CBM_GLOBAL_RESET_REQ on line 27.
Done
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 167: #define CSE_RESET_ONLY 3
These flags grouped with cse_hmrfpo_enable() in the patch - https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 170: #define MKHI_HMRFPO_DISABLED 0 : #define MKHI_HMRFPO_LOCKED 1 : #define MKHI_HMRFPO_ENABLED 2
These flags grouped with cse_hmrfpo_enable() in the patch - https://review.coreboot. […]
Done