Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44273 )
Change subject: mb/google/zork: Cleanup bt reset_gpio removal ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44273/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44273/2/src/mainboard/google/zork/v... PS2, Line 65: usb_dev = find_dev_nested_path( flow on the same line?
https://review.coreboot.org/c/coreboot/+/44273/2/src/mainboard/google/zork/v... PS2, Line 68: printk(BIOS_ERR, "%s: Failed to find USB device!", __func__); you can pass in a name so you can specify which xhci controller number you were expecting. That way you'll have better debug messages.