Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83922?usp=email )
Change subject: soc/mediatek/mt8196: Add GPIO driver ......................................................................
Patch Set 7:
(2 comments)
File src/soc/mediatek/mt8196/gpio.c:
https://review.coreboot.org/c/coreboot/+/83922/comment/13584bb0_38b95463?usp... : PS6, Line 391: const struct gpio_drv_info *get_gpio_driving_info(uint32_t raw_id) : { : if (raw_id >= ARRAY_SIZE(gpio_driving_info)) { : printk(BIOS_ERR, "Error: raw_id is out of range\n"); : return NULL; : } : return &gpio_driving_info[raw_id]; : } : : const struct gpio_drv_info *get_gpio_driving_adv_info(uint32_t raw_id) : { : if (raw_id >= ARRAY_SIZE(gpio_driving_adv_info)) { : printk(BIOS_ERR, "Error: raw_id is out of range\n"); : return NULL; : } : return &gpio_driving_adv_info[raw_id]; : }
These two functions mainly serve the callers in `src/soc/mediatek/common/gpio.c`. […]
please review here CL:83987
File src/soc/mediatek/mt8196/include/soc/gpio_base.h:
PS4:
MT8173 has an even simpler definition: […]
Please review here CL:83988.