Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42831 )
Change subject: soc/amd/picasso: Use cbfs to locate the AMD firmware
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/42831/2/src/soc/amd/picasso/psp_ver...
PS2, Line 89: (uint32_t)boot_dev.base);
Martin, can you please elaborate on that? What addresses are you getting that are different? I'm not […]
Nevermind. I see now. Are the values of psp_table and bios1_entry pointers in memory-mapped x86 view of things? Or are they offests in SPI flash address space?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27b0593e0db7a9e6ba9b0633ac93b4d93954f002
Gerrit-Change-Number: 42831
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 19:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment