Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42331 )
Change subject: mb/google/volteer: update fw_config definition
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42331/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42331/3/src/mainboard/google/voltee...
PS3, Line 3: DB_USB
i think we don't need the prefixes in options.
looking at sconfig, we always compose the symbol names with
the field name and option name concatenated, so this is
kinda redundant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761893818231880d86fd13cfa61319157d06a7d5
Gerrit-Change-Number: 42331
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 18 Jun 2020 22:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment