[coreboot-gerrit] [S] Change in coreboot[main]: lib: Refactor bmp_load_logo() implementation

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Kapil Porwal, Ronak Kanabar, Sean Rhodes.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )

Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/mendocino/fsp_s_params.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/dca3701b_265a1b91 :
PS4, Line 59: 	supd->FspsConfig.logo_bmp_buffer = (uint32_t)(uintptr_t)bmp_load_logo(&logo_size);
> I'm curious why the logo size isn't updated in the FspsConfig.

because this is Intel owned and managed by FSP. FSP UPDs are unified for API and dispatch mode hence in summary, to make any change in FspsConfig, we need to change the FSP source code.