John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38503 )
Change subject: mb/google/drallion: Remove fixed IccMax values
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38503/1//COMMIT_MSG@7
PS1, Line 7: UPSTREAM
Remove the "UPSTREAM" from subject line.
Done
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38503/1/src/mainboard/google/dralli...
PS1, Line 79: #| IccMax | 6A | 70A | 31A | 31A |
add some logs here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcd31ad5b608ce599d4294a6522fdda022f8a177
Gerrit-Change-Number: 38503
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 22 Jan 2020 06:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment