Attention is currently required from: Bao Zheng, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59581 )
Change subject: amdfwtool: remove duplicates ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59581/comment/a813ce1d_f5614a69 PS1, Line 12: TEST=build guybrush and confirm amdfw and coreboot.rom are identical
this needs to be tested on picasso and stoneyridge where it might make a difference. the cezanne fw. […]
I don't think smu firmware makes any difference here since only duplicate entries are removed. (e.g. line 235 and line 271 in amdfwtool.c)
For picasso I checked amdfw.rom is identical with this whole CL chain. However on stoney it's a bit different because AMD_FW_PSP_TRUSTLETS and AMD_FW_PSP_SECURED_DEBUG, there are both code to check command line config and not to check (see line 135 and line 207 in data_parse.c) and code not checking comes before in if-else block so they were added unconditionally.
On picasso and cezanne we set unlock_secure and use_secureos so they are added anyway but on grunt we don't set those flags so it's now removed.
I confirmed that if I add AMD_FW_PSP_TRUSTLETS and AMD_FW_PSP_SECURED_DEBUG files unconditionally amdfw.rom is identical. I don't know any history why this work like this but do you think we should add them on stoney?