Attention is currently required from: Varshit B Pandya, Subrata Banik, Rizwan Qureshi.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62945 )
Change subject: ec/google: Add PSRC and PBOK method
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/62945/comment/c49a3bc6_e15d7aaf
PS2, Line 138: cpigen_write_store();
: acpigen_emit_byte(ARG0_OP);
: acpigen_emit_byte(LOCAL0_OP);
:
: acpigen_emit_byte(AND_OP);
: acpigen_emit_byte(LOCAL0_OP);
: acpigen_write_byte(0x0F);
: acpigen_emit_byte(LOCAL0_OP);
I think what Eric means if you can simplify this to:
```
/* Local0 = Arg0 & 0x0f
acpigen_emit_byte(AND_OP);
acpigen_emit_byte(ARG0_OP);
acpigen_write_byte(0x0f);
acpigen_emit_byte(LOCAL0_OP);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia536a9e1528f6e415247eca9ed2b0b685eb73196
Gerrit-Change-Number: 62945
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 21:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment