Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 37:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 21: CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
not required
is definitely required as neither $(src)/mainboard/$(MAINBOARDDIR) nor $(src)/mainboard/$(MAINBOARDDIR)/include are added per default; compare src/mainboard/intel/harcuvar/Makefile.inc, src/mainboard/emulation/qemu-aarch64/Makefile.inc, src/mainboard/emulation/qemu-riscv/Makefile.inc and some others.
Build fails without this
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x... PS35, Line 18: #include <mainboard.h>
include/mainboard. […]
Done