Attention is currently required from: Felix Singer, Jamie Ryu, Subrata Banik, Ethan Tsao, Paul Menzel, Raj Astekar, Ravishankar Sarawadi.
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS4:
Any guidance/documentation on HOW-TOs for stage-wise Make build setup? Wondering when building c […]
SOC incremental code is WIP, I will update asap.
File src/soc/intel/meteorlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/ec166208_77893d3a
PS5, Line 14: include <intelblocks/ioc.h>
I don't see this file in upstream yet.
https://review.coreboot.org/c/coreboot/+/63198
File src/soc/intel/meteorlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/62772/comment/5014d376_daa65494
PS5, Line 50: PCI_DID_INTEL_SIMICS_GT0, "Meteorlake simics w/o IGD"
?? seriously ?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4
Gerrit-Change-Number: 62772
Gerrit-PatchSet: 6
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 04 Apr 2022 07:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-MessageType: comment