Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68490 )
Change subject: mb/google/geralt: Configure firmware display for eDP panel ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/geralt/display.h:
https://review.coreboot.org/c/coreboot/+/68490/comment/957b51b6_54779f64 PS5, Line 8: bool If there's no good reason, please use `int` as the return type.
File src/mainboard/google/geralt/display.c:
https://review.coreboot.org/c/coreboot/+/68490/comment/60be296b_c3972c8e PS5, Line 47: false -1
https://review.coreboot.org/c/coreboot/+/68490/comment/dcebb434_999407d2 PS5, Line 63: true 0
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68490/comment/ac9b4eb8_215d51a6 PS5, Line 15: ! And here