Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43810 )
Change subject: smp/spinlock: Do not define barrier() globally
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43810/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43810/2//COMMIT_MSG@10
PS2, Line 10: name collisions with other
: barrier()
CB:43822 handles one collision. Maybe we should define those sfence, mfence things in a header
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae187b5bcc249c2a4bc7bee80d37e34c13d9e63d
Gerrit-Change-Number: 43810
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 14:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment