Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/25785 )
Change subject: siemens/mc_apl1: Provide baseboard and variant concepts ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@9 PS1, Line 9: Apollo Lak
Add a spce: Apollo Lake
Done
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@10 PS1, Line 10: reference
reference
Done
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@11 PS1, Line 11:
remove this comma
Done
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@17 PS1, Line 17:
can be removed
Done
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@18 PS1, Line 18:
can be removed
Done
https://review.coreboot.org/#/c/25785/1//COMMIT_MSG@25 PS1, Line 25: be added under
be added
Done
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfi... File src/mainboard/siemens/mc_apl1/Kconfig:
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/Kconfi... PS1, Line 7: select USE_SIEMENS_HWILI
I would better activate the (final) board specific switches in the variants Kconfig rather than here […]
There is now also a Kconfig file in the subfolder and the board-specific stuff is moved there .
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/25785/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 17: <commonlib/helpers.h>
Make this include the last one in the list.
Done