Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60396 )
Change subject: soc/mediatek/mt8186: Add DDP driver ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60396/comment/d4812618_e60703ba PS3, Line 11:
Is there a Linux kernel driver, and are they quite similar?
yes, we implement ddp in gpu/drm/mediatek. the main path is the same.
File src/soc/mediatek/mt8186/ddp.c:
https://review.coreboot.org/c/coreboot/+/60396/comment/7042a2e2_e120dc07 PS3, Line 13: * POSTMASK0->DITHER->DSI0
Fits on the line above?
Done
https://review.coreboot.org/c/coreboot/+/60396/comment/8024eeeb_b41378c6 PS3, Line 136: /* Turn off M4U port. */
Remove dot/period at the end?
Done