Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Julius Werner, Marvin Drees, Paul Menzel.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79106?usp=email )
Change subject: arch/arm64: Extend cache helper functions
......................................................................
Patch Set 11:
(1 comment)
File src/arch/arm64/armv8/cache.c:
https://review.coreboot.org/c/coreboot/+/79106/comment/89ab28a3_68aa9782 :
PS8, Line 63: /* [2:0] - Indicates (Log2(Number of bytes in cache line) - 4) */
: uint8_t line_length = 1 << ((ccsidr_el1 & 0x7) + 4);
: /* (Number of sets in cache) - 1 */
: uint64_t num_sets = get_ccsidr_el1_numsets(ccsidr_el1) + 1;
: /* (Associativity of cache) - 1 */
: *assoc = get_ccsidr_el1_assoc(ccsidr_el1) + 1;
Can you return the comments? The helpers we use don't extract human readable data from raw registers […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79106?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6fe731dc67ffeaff9344d2bd2627f45185c27de
Gerrit-Change-Number: 79106
Gerrit-PatchSet: 11
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Comment-Date: Tue, 23 Apr 2024 14:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment