[coreboot-gerrit] Change in coreboot[master]: soc/intel/{common,skl,dnv}: set ACPI_FADT_PLATFORM_CLOCK based on Kco...

[Nico Huber (Code Review)]

Attention is currently required from:  Felix Singer, Furquan Shaikh, Mariusz Szafrański, Paul Menzel, Subrata Banik, Angel Pons, Michael Niewöhner, Patrick Rudolph, Lance Zhao, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57934 )

Change subject: soc/intel/{common,skl,dnv}: set ACPI_FADT_PLATFORM_CLOCK based on Kconfig
......................................................................

Patch Set 17:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/57934/comment/e5937b6b_a419d757 
PS17, Line 12:  or not.
Nit, not accurate. Setting a 1 requires a compliant timer, but a
0 basically says nothing.

Patchset:

PS17: 
Generally, I believe it's best to follow this simple rule when patching:
* Each commit should change the code base from one consistent state to another.

Well, we have to adapt to reality here, because the code never looks
consistent before a patch anyway. However, I'd say we can still strive
towards not making things more confusing.

For instance, this commit changes some ACPI advertisement for DNV based
on a Kconfig option. But the DNV code actually doesn't honor this option,
hence the state after this commit is inconsistent. In this case, it's easy
to fix because the code is adapted to honor the option later. You'd just
have to shuffle the order of changes in your train. If you do that, commits
can be reviewed and even merged in-order, reducing the queue quickly,
without much hassle.