26 Feb
2019
26 Feb
'19
8:59 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31491 )
Change subject: [WIP] console: Refactor printk() varargs prototypes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31491/1/src/include/console/console.h File src/include/console/console.h:
https://review.coreboot.org/#/c/31491/1/src/include/console/console.h@92 PS1, Line 92: va_start(args, fmt); Aren't these implemented as macros? If we don't know how much code this produces, is inlining a good choice?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31491
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I816641c2223c3079ad9c95c1380d4b250898ef93
Gerrit-Change-Number: 31491
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 26 Feb 2019 11:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment