Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43510 )
Change subject: tests: Add lib/bootmem-test test case ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c File tests/lib/bootmem-test.c:
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c@93 PS1, Line 93: test_ Since this isn't actually a test, I don't think it should have a test_ prefix. Same comment goes for test_basic_teardown, test_bootmem_walk_setup and test_bootmem_walk_teardown.
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c@12... PS1, Line 122: /* This test need to be run first, in order to use bootmem library API */ Requiring tests to be run in a specific order is usually a sign that the tests have hidden dependencies. It would be better to figure out and fix the problems. However, if you're going to leave it like this, then the comment should also be copied into the block in main() where the order of the tests is actually specified.
https://review.coreboot.org/c/coreboot/+/43510/1/tests/lib/bootmem-test.c@15... PS1, Line 150: bool These functions only get called once, and their return value is not used. Either declare them as void, or assert_true on the return value.