Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84195?usp=email )
Change subject: Cezanne: Add an option to enable A/B recovery scheme
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84195/comment/a8889f51_4dd2aedb?usp... :
PS1, Line 9: Non A/B recovery
This would simply be no recovery method, right? (Although vboot is an alternative methodology. […]
Done
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/84195/comment/8effe557_325ad0c5?usp... :
PS1, Line 412: "Recovery A/B"
maybe "Use A/B Recovery scheme"?
Done
https://review.coreboot.org/c/coreboot/+/84195/comment/0543d713_bf653c14?usp... :
PS1, Line 415: Recovery A/B
How about "Enable the PSP A/B Recovery mechanism"? Also, should we put some words in here about vbo […]
I dont know much about vboot's role in A/B recovery.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1c8028faee9c544628d65fd77be2a378ed7eab6
Gerrit-Change-Number: 84195
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 04 Sep 2024 08:17:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com