Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31661 )
Change subject: soc/intel/braswell: Add SMBus support
......................................................................
Patch Set 2:
Was thinking about this solution, but unsure about the impact on boards with
'SOUTHBRIDGE_INTEL_COMMON' disabled, but 'SOUTHBRIDGE_INTEL_COMMON_SMBUS' enabled.
are there any such boards? surely that selection would be a noop in the present state, since smbus.c wouldn't be compiled (unless it were included as your patch currently does)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d4f657558a1aed21b083ef5cad08ea96e629c3
Gerrit-Change-Number: 31661
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 09:28:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment