Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39987 )
Change subject: [WIP] mb/ocp/tiogapass: use ACPI to control GPIO
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/39987/35/src/mainboard/ocp/tiogapas...
PS35, Line 23: #include <soc/intel/xeon_sp/acpi/gpio.asl>
This should be added to xeon_sp/acpi/pch.asl
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d4526c423b2192f51e515d993a05c03a3eaf58b
Gerrit-Change-Number: 39987
Gerrit-PatchSet: 35
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Nov 2020 17:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment