Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40645 )
Change subject: mb/google/deltaur: Enable SPD_READ_BY_WORD
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I guess I'd prefer we check that it's actually going to help reduce boot time.
And if so, I'd just select it at SoC level, or are there any downsides?
As long as everybody (SoC & memory) is SMBus compliant, it shouldn't matter 😄.
If it does result in faster boot, I think these are the first TGL boards in coreboot,
so it would probably be OK to select it for the SoC. If anyone has issues, they can
set it to n for their mainboard. Angel, Paul, what do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib68e830c25d95e8498eead155b2fa881b0ae0313
Gerrit-Change-Number: 40645
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 23:03:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment