Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35635 )
Change subject: mb: remove test-only HWIDs
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
LGTM once we find a good solution for the first patch.
https://review.coreboot.org/c/coreboot/+/35635/2/src/mainboard/google/auron/...
File src/mainboard/google/auron/Kconfig:
https://review.coreboot.org/c/coreboot/+/35635/2/src/mainboard/google/auron/...
PS2, Line 51: A-A
Do theses A-A mean anything?
That's just how original v2 test HWIDs looked like, to match the expected format (a real v2 ID one would be something like "SNOW BAKER BA-C"... <board> <BOM> <variant>-<volatiles>). I guess once we realized that nothing that parses it still cares about having the other two strings separated by a dash in there, we started omitting it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4070f09d29c5601dff1587fed8c60714eb2558b7
Gerrit-Change-Number: 35635
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 28 Sep 2019 00:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Gerrit-MessageType: comment