Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42926 )
Change subject: ACPI: Call mainboard_fill_gnvs() early
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42926/1/src/acpi/gnvs.c
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/42926/1/src/acpi/gnvs.c@60
PS1, Line 60: soc_fill_gnvs(gnvs);
soc_fill_gnvs() calls dev_count_cpu(), too early for that to be filled here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I515e830808a95eee3ce72b16fd26da6ec79dac85
Gerrit-Change-Number: 42926
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 02 Jul 2020 01:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment