Attention is currently required from: Cliff Huang, Sridhar Siricilla, Bernardo Perez Priego, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55989 )
Change subject: cbfstool: Add helper function `buffer_from_file_aligned_size`
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
not sure if i'm misinterpreting what this is supposed to do or what it does, but shouldn't this be g […]
The change is ensuring that the buffer size that is allocated for reading the file is aligned to a multiple of the align attribute. I see your point about the usage of terms "alignment" and "granularity". Does this change make it somewhat clear:
```
int buffer_from_file_roundup_size(struct buffer *buffer, const char *filename, size_t size_granularity)
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad3430d476abcdad850505ac50e36cd5d5deecb4
Gerrit-Change-Number: 55989
Gerrit-PatchSet: 12
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Oct 2021 06:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment