Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... File src/mainboard/facebook/fbg1701/mainboard.c:
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 25: void mainboard_configure_edp_bridge(void)
Since it's mainboard specific it's placed in the mainboard.c file.
Done
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 27: edp_data_t *edptable;
Target is a const array.
Done
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 41: smbus_i2c_block_write(edptable->address, edptable->offset,
The call should work fine with const arguments, also check return value for errors, in case you need […]
Add check for error Did not use const argument for new patchset, cause do_i2c_block_write() is modify parameters.