Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )
Change subject: /soc/amd/picasso: Generate ACPI pstate and cstate objects in cb ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45340/5/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/45340/5/src/soc/amd/picasso/Kconfig... PS5, Line 347:
Help text is indented by two spaces following the tab.
Ack
https://review.coreboot.org/c/coreboot/+/45340/5/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45340/5/src/soc/amd/picasso/acpi.c@... PS5, Line 343: 3
curious why 3. It looks like we're only doing 2.
PPR says that we support up to 3 Cstates, however it only defines values for C1 and C2 and agesa does not have C3 enabled or C3 latency values defined from calculation. Will change to 2, since any change adding the 3rd cstate would also increase the size of the array.