Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Sudheer Amrabadi, Julius Werner, Arthur Heymans.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59194 )
Change subject: src/lib: Add CBMEM tag id to parse ddr information
......................................................................
Patch Set 26:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59194/comment/a8961155_90c0d78b
PS21, Line 9: BUG=b:182963902,177917361
Ack
You acked this, but didn't make the actual change.
https://review.coreboot.org/c/coreboot/+/59194/comment/bd4ce03d_daeb277d
PS21, Line 10: developement
Ack
same here.
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/59194/comment/e8acaabf_9981a88e
PS21, Line 157: { CBMEM_ID_TYPE_C_INFO, "TYPE_C INFO"}, \
This looks like a duplicate entry was accidentally introduced.
This is still here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594bd9266a6379e3a85de507eaf4c56619b17a6f
Gerrit-Change-Number: 59194
Gerrit-PatchSet: 26
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney
quic_mturney@quicinc.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 21:25:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-MessageType: comment