HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )
Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass...
PS5, Line 2: /* This file is part of the coreboot project. */
please, remove
https://review.coreboot.org/c/coreboot/+/40547/5/src/mainboard/ocp/tiogapass...
PS5, Line 20: TYPE_OTHER
TYPE_OTHER_PORT
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356e645774d78c623c1398c8b1473562e1529cf2
Gerrit-Change-Number: 40547
Gerrit-PatchSet: 5
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Jul 2020 09:10:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment