Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44645 )
Change subject: mb/google/dedede: Fix board specific CSE reset ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44645/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44645/1/src/mainboard/google/dedede... PS1, Line 18: outb(FULL_RST | SYS_RST, RST_CNT);
I can not add inside google_chromeec_ap_reset since the EC command is architecture-independent and t […]
I wonder if this entire function should be moved to src/vendorcode/google/chromeos/ so that all mainboards needing it can take advantage of it. And have mainboard select a Kconfig that pulls in the required file that provides this.
Also, I think we should add a dcache_clean_all() before the outb() just like it is done here: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...