Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44538 )
Change subject: soc/amd/picasso: Reboot for recovery if no psp workbuf is found ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/psp_verstage.h:
https://review.coreboot.org/c/coreboot/+/44538/3/src/soc/amd/picasso/psp_ver... PS3, Line 34: POSTCODE_CMOS_RECOVERY Everything in this patch looks good. However, these values are for post_code(). However, this one is not used for that. It's used as a return value for a vboot error. This should be renamed or we should be using VB_ERROR_X defines.