Attention is currently required from: Paul Menzel, chris wang, Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48734 )
Change subject: mb/google/zork: add edp tunning parameter to fix the edp noise ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48734/comment/6697fb5b_e2f7548f PS5, Line 30: register "edp_table_size" = "0x05"
haven't really figured out what this does on the fsp side exactly, but it does seem rather odd to me […]
I would think this would be the resulting size of dptuning[] table that gets initialized in FSP. Current FSP implementation is only using one of the entries in the table (1 * sizeof(edp_tuningset)) which results in 5 byte table. We do need to double check if the units here are bytes or number of valid edp_tuningset(s) which would be 1 in this case. Adding Eddie to the review to verify.