[coreboot-gerrit] [S] Change in coreboot[master]: security/intel/txt: Helper function to disable TXT

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Angel Pons, Lean Sheng Tan, Werner Zeh.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71574 )

Change subject: security/intel/txt: Helper function to disable TXT
......................................................................

Patch Set 1:

(1 comment)

File src/security/intel/txt/txtlib.c:

https://review.coreboot.org/c/coreboot/+/71574/comment/8d3d1e7f_0f723ee5 
PS1, Line 57: /* Don't disable if INTEL_TXT config is selected */
            : 	if (CONFIG(INTEL_TXT))
            : 		return;
> Having a disable function which does not disable anything depending on a Kconfig value, is a bit confusing? Would it make sense to call it something like 'early_intel_txt_setup' ?

Ideally `early_intel_txt_setup()` should setup or init something (isn't it). Where else this function does exactly opposite of setting up the txt.