Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58240 )
Change subject: drivers/pc80/tpm: Use stopwatch for timeout-loops
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/58240/comment/47fad25b_3b86b72e
PS1, Line 256: while (!stopwatch_expired(&sw)) {
: u8 value = tpm_read_status(locality);
: if ((value & mask) == expected)
: return 0;
: }
nit: I'd use a do-while loop to ensure the loop body is executed at least once. It probably makes no difference in practice, but I think it's slightly more correct.
https://review.coreboot.org/c/coreboot/+/58240/comment/91d71342_9802ac28
PS1, Line 462: %d bytes of %d
For another patch: These two `%d` should be `%u`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd261c9d60a9a60509c847dbc4983bc05f41d48
Gerrit-Change-Number: 58240
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 09:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment