HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61557 )
Change subject: src/drivers: Get rid of unnecessary blank lines {before,after} blace ......................................................................
src/drivers: Get rid of unnecessary blank lines {before,after} blace
Change-Id: Ic1b38e93d919c1286a8d130700a4a2bfd6b55258 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/amd/agesa/heapmanager.c M src/drivers/amd/agesa/state_machine.c M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_post.c M src/drivers/crb/tis.c M src/drivers/crb/tpm.c M src/drivers/generic/max98357a/chip.h M src/drivers/i2c/tpm/tpm.c M src/drivers/i2c/ww_ring/ww_ring.c M src/drivers/intel/fsp1_1/car.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/header_display.c M src/drivers/intel/gma/opregion.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/ipmi/ipmi_fru.c M src/drivers/net/ne2k.c M src/drivers/pc80/rtc/mc146818rtc.c M src/drivers/smmstore/store.c M src/drivers/spi/tpm/tis.c M src/drivers/tpm/ppi.c M src/drivers/usb/ehci.h 22 files changed, 1 insertion(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/61557/1
diff --git a/src/drivers/amd/agesa/heapmanager.c b/src/drivers/amd/agesa/heapmanager.c index c1fac0d..2910c9d 100644 --- a/src/drivers/amd/agesa/heapmanager.c +++ b/src/drivers/amd/agesa/heapmanager.c @@ -346,7 +346,6 @@ AllocParams->BufferLength = AllocNodePtr->BufferSize;
return AGESA_SUCCESS; - }
AGESA_STATUS HeapManagerCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr) diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 31db0b6..ef33cc5 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -159,7 +159,6 @@ { break; } - } return status; } @@ -222,7 +221,6 @@ { break; } - } return status; } diff --git a/src/drivers/aspeed/common/ast_dp501.c b/src/drivers/aspeed/common/ast_dp501.c index 924ca57..ba0833c 100644 --- a/src/drivers/aspeed/common/ast_dp501.c +++ b/src/drivers/aspeed/common/ast_dp501.c @@ -146,7 +146,6 @@
data = ast_mindwm(ast, 0x1e6e2100) & 0x01; if (!data) { - if (ast->dp501_fw_addr) { fw_addr = ast->dp501_fw_addr; len = 32*1024; diff --git a/src/drivers/aspeed/common/ast_mode.c b/src/drivers/aspeed/common/ast_mode.c index e5832e7..3ab91c2 100644 --- a/src/drivers/aspeed/common/ast_mode.c +++ b/src/drivers/aspeed/common/ast_mode.c @@ -26,7 +26,6 @@ /* FIXME: Gamma cor 2.6 ? */ for (int i = 0; i < 256; i++) ast_load_palette_index(ast, i, i, i, i); - }
static bool ast_get_vbios_mode_info(struct drm_crtc *crtc, struct drm_display_mode *mode, diff --git a/src/drivers/aspeed/common/ast_post.c b/src/drivers/aspeed/common/ast_post.c index e644d91..08bc42c 100644 --- a/src/drivers/aspeed/common/ast_post.c +++ b/src/drivers/aspeed/common/ast_post.c @@ -788,8 +788,8 @@ } reg_mcr18 = reg_mcr18 | (g_dqidly << 16) | (g_dqsip << 23); ast_moutdwm(ast, 0x1E6E0018, reg_mcr18); - } + static bool cbr_dll2(struct ast_private *ast, struct ast2300_dram_param *param) { u32 dllmin[2], dllmax[2], dlli, data, passcnt, retry = 0; @@ -1085,7 +1085,6 @@ param->dram_config |= 0x0c; break; } - }
static void ddr3_init(struct ast_private *ast, struct ast2300_dram_param *param) @@ -1226,7 +1225,6 @@ ast_moutdwm(ast, 0x1E6E0050, 0x80000000); ast_moutdwm(ast, 0x1E6E0050, 0x00000000); #endif - }
static void get_ddr2_info(struct ast_private *ast, struct ast2300_dram_param *param) @@ -1617,7 +1615,6 @@ ast_moutdwm(ast, 0x1E6E0050, 0x80000000); ast_moutdwm(ast, 0x1E6E0050, 0x00000000); #endif - }
static void ast_post_chip_2300(struct drm_device *dev) @@ -1883,7 +1880,6 @@
static void ddr3_init_2500(struct ast_private *ast, const u32 *ddr_table) { - ast_moutdwm(ast, 0x1E6E0004, 0x00000303); ast_moutdwm(ast, 0x1E6E0010, ddr_table[REGIDX_010]); ast_moutdwm(ast, 0x1E6E0014, ddr_table[REGIDX_014]); diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index 800d145..dc61c1e 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -51,7 +51,6 @@ int tis_close(void) { if (tpm_is_open) { - /* * Do we need to do something here, like waiting for a * transaction to stop? diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 9c8f249..1bdca00 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -110,7 +110,6 @@ */ static uint8_t crb_activate_locality(void) { - uint8_t locality = (read8(CRB_REG(0, CRB_REG_LOC_STATE)) >> 2) & 0x07; printk(BIOS_SPEW, "Active locality: %i\n", locality);
@@ -174,7 +173,6 @@ */ int tpm2_init(void) { - if (crb_probe()) { printk(BIOS_ERR, "TPM: Probe failed.\n"); return -1; diff --git a/src/drivers/generic/max98357a/chip.h b/src/drivers/generic/max98357a/chip.h index 1c4aa3d..66ebecf 100644 --- a/src/drivers/generic/max98357a/chip.h +++ b/src/drivers/generic/max98357a/chip.h @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h>
struct drivers_generic_max98357a_config { - /* ACPI _HID */ const char *hid;
diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c index b96099c..840b947 100644 --- a/src/drivers/i2c/tpm/tpm.c +++ b/src/drivers/i2c/tpm/tpm.c @@ -346,7 +346,6 @@ burstcnt); if (rc == 0) size += burstcnt; - } return size; } diff --git a/src/drivers/i2c/ww_ring/ww_ring.c b/src/drivers/i2c/ww_ring/ww_ring.c index 19aa6da..98c162b 100644 --- a/src/drivers/i2c/ww_ring/ww_ring.c +++ b/src/drivers/i2c/ww_ring/ww_ring.c @@ -375,7 +375,6 @@ for (i = 0, ledc = lp55231s; i < WW_RING_NUM_LED_CONTROLLERS; i++, ledc++) { - ledc->i2c_bus = i2c_bus; ledc->dev_addr = LP55231_I2C_BASE_ADDR + i;
diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 5d41a01..fc05b91 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -19,7 +19,6 @@ * with different TSEG size configurations. */ top_of_ram = ALIGN_DOWN((uintptr_t)cbmem_top(), 8*MiB); postcar_frame_add_mtrr(pcf, top_of_ram - 8*MiB, 16*MiB, MTRR_TYPE_WRBACK); - }
/* This is the romstage entry called from cpu/intel/car/romstage.c */ diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index fd8316e..386708f 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -129,7 +129,6 @@
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) continue;
@@ -193,7 +192,6 @@
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_GUID_EXTENSION) continue;
diff --git a/src/drivers/intel/fsp2_0/header_display.c b/src/drivers/intel/fsp2_0/header_display.c index 4c8085e..3241856 100644 --- a/src/drivers/intel/fsp2_0/header_display.c +++ b/src/drivers/intel/fsp2_0/header_display.c @@ -44,5 +44,4 @@ printk(BIOS_SPEW, "\tNotify phase offset 0x%zx\n", (size_t)hdr->notify_phase_entry_offset); } - } diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 430bda3..63e248c 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -290,7 +290,6 @@ static void opregion_add_ext_vbt(igd_opregion_t *opregion, uint8_t *ext_vbt, optionrom_vbt_t *vbt) { - opregion_header_t *header = &opregion->header; /* Copy VBT into extended VBT region (at offset 8 KiB) */ memcpy(ext_vbt, vbt, vbt->hdr_vbt_size); diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 4e4a92c..7220f27 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -356,7 +356,6 @@ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
for (dfp_port = 0; dfp_port < DFP_NUM_MAX; dfp_port++) { - if (!config->dfp[dfp_port].power_gpio.pin_count) { printk(BIOS_ERR, "%s: No DFP%1d power GPIO for %s\n", __func__, dfp_port, dev_path(dev)); diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c index d26a9b7..822e5bf 100644 --- a/src/drivers/ipmi/ipmi_fru.c +++ b/src/drivers/ipmi/ipmi_fru.c @@ -571,5 +571,4 @@ printk(BIOS_DEBUG, "chassis custom data %i: %s\n", count, *(chassis_info.chassis_custom + count)); } - } diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index 83d4ccf..235c909 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -124,7 +124,6 @@ int acc = 0;
do { - c = str[i]; if ((c >= '0') && (c <= '9')) { acc *= 16; diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index fd659f1..f45a3a0 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -267,7 +267,6 @@ /* If we are in normal mode set the boot count to 0 */ if (byte & RTC_BOOT_NORMAL) byte &= 0x0f; - }
outb(byte, RTC_PORT(1)); diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 24e8a88..9d19a7c 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -161,7 +161,6 @@ return CB_ERR;
return CB_SUCCESS; - } /* * Append data to region diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 6465b40..da4c1a8 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -40,7 +40,6 @@ int tis_close(void) { if (tpm_is_open) { - /* * Do we need to do something here, like waiting for a * transaction to stop? diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index 6b02d45..6183e3b 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -582,7 +582,6 @@ found = true; } } else { - for (size_t i = 0; i < ARRAY_SIZE(tpm2_funcs); i++) { ppib->func[tpm2_funcs[i]] = 1; if (ppib->pprq == tpm2_funcs[i]) diff --git a/src/drivers/usb/ehci.h b/src/drivers/usb/ehci.h index 9635460..b9054cf 100644 --- a/src/drivers/usb/ehci.h +++ b/src/drivers/usb/ehci.h @@ -42,7 +42,6 @@
/* Section 2.3 Host Controller Operational Registers */ struct ehci_regs { - /* USBCMD: offset 0x00 */ u32 command;