Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32858 )
Change subject: console: Move poor-man's atoi() into string.h ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/32858/3/src/include/string.h File src/include/string.h:
https://review.coreboot.org/#/c/32858/3/src/include/string.h@182 PS3, Line 182: a positive integer
'an integer without a sign' because it works for 0 (not a positive integer) and fails for '+1' (whic […]
Okay, I'll say unsigned.
https://review.coreboot.org/#/c/32858/3/src/include/string.h@183 PS3, Line 183:
Parameter `s` and `*s` must be valid pointers. […]
Added details.
https://review.coreboot.org/#/c/32858/3/src/include/string.h@184 PS3, Line 184: static inline
Why not put this function to the `string. […]
Let me do that in a separate CL since it gets a bit more complicated with Makefiles and stuff (and that argument applies to a bunch more functions in here, not just this one).
AFAIK we don't use LTO and LTO is also still not all it's hyped to be in 2019. But there are a bunch of functions here that don't look like they would benefit particularly much from inlining so I think moving them to C code makes sense.