Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84896?usp=email )
Change subject: soc/mediatek/mt8196: Disable irq2axi feature
......................................................................
Patch Set 3: Code-Review+1
(4 comments)
File src/soc/mediatek/mt8196/include/soc/irq2axi.h:
https://review.coreboot.org/c/coreboot/+/84896/comment/857594b8_b245840d?usp... :
PS3, Line 6: #include <device/mmio.h>
move to c file
https://review.coreboot.org/c/coreboot/+/84896/comment/f73a147e_2e700e78?usp... :
PS3, Line 8:
use tab for indent
https://review.coreboot.org/c/coreboot/+/84896/comment/8953ce30_19fc34a1?usp... :
PS3, Line 13: (
remove parentheses
https://review.coreboot.org/c/coreboot/+/84896/comment/e3aafc08_f5d407e2?usp... :
PS3, Line 16: )
ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84896?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e89a0ee75e574a4b9e8df0a0f6a5f6e03bba2d6
Gerrit-Change-Number: 84896
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Runyang Chen
runyang.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 06:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes