Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75668?usp=email )
Change subject: soc/amd/*/root_complex: use VGA_MMIO_* defines ......................................................................
soc/amd/*/root_complex: use VGA_MMIO_* defines
Replace the magic constants by using defines.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I16179a37b6ee19bc3b4862b7dcb3bbc4caf63f2e Reviewed-on: https://review.coreboot.org/c/coreboot/+/75668 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/amd/cezanne/root_complex.c M src/soc/amd/glinda/root_complex.c M src/soc/amd/mendocino/root_complex.c M src/soc/amd/phoenix/root_complex.c M src/soc/amd/picasso/root_complex.c 5 files changed, 10 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/amd/cezanne/root_complex.c b/src/soc/amd/cezanne/root_complex.c index cb35662..bbddfab 100644 --- a/src/soc/amd/cezanne/root_complex.c +++ b/src/soc/amd/cezanne/root_complex.c @@ -6,6 +6,7 @@ #include <amdblocks/ioapic.h> #include <amdblocks/memmap.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <cbmem.h> #include <console/console.h> #include <device/device.h> @@ -121,7 +122,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 - 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 - 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB); diff --git a/src/soc/amd/glinda/root_complex.c b/src/soc/amd/glinda/root_complex.c index 071903d..64d90ee 100644 --- a/src/soc/amd/glinda/root_complex.c +++ b/src/soc/amd/glinda/root_complex.c @@ -8,6 +8,7 @@ #include <amdblocks/ioapic.h> #include <amdblocks/memmap.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <cbmem.h> #include <console/console.h> #include <device/device.h> @@ -136,7 +137,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 - 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 - 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB); diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index 492a588..6f93502 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -8,6 +8,7 @@ #include <amdblocks/ioapic.h> #include <amdblocks/memmap.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <cbmem.h> #include <console/console.h> #include <device/device.h> @@ -164,7 +165,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 - 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 - 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB); diff --git a/src/soc/amd/phoenix/root_complex.c b/src/soc/amd/phoenix/root_complex.c index f7c4c1e..64f9ca4 100644 --- a/src/soc/amd/phoenix/root_complex.c +++ b/src/soc/amd/phoenix/root_complex.c @@ -8,6 +8,7 @@ #include <amdblocks/ioapic.h> #include <amdblocks/memmap.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <cbmem.h> #include <console/console.h> #include <device/device.h> @@ -136,7 +137,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 - 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 - 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB); diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 7a83197..e61208f 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -6,6 +6,7 @@ #include <amdblocks/memmap.h> #include <amdblocks/ioapic.h> #include <arch/ioapic.h> +#include <arch/vga.h> #include <assert.h> #include <cbmem.h> #include <console/console.h> @@ -121,7 +122,7 @@ ram_resource_kb(dev, idx++, 0, 0xa0000 / KiB);
/* 0xa0000 - 0xbffff: legacy VGA */ - mmio_resource_kb(dev, idx++, 0xa0000 / KiB, 0x20000 / KiB); + mmio_resource_kb(dev, idx++, VGA_MMIO_BASE / KiB, VGA_MMIO_SIZE / KiB);
/* 0xc0000 - 0xfffff: Option ROM */ reserved_ram_resource_kb(dev, idx++, 0xc0000 / KiB, 0x40000 / KiB);