[coreboot-gerrit] Change in coreboot[master]: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Dmitry Ponamorev, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michal Motyl, Patrick Rudolph, King Sumo.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )

Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8
......................................................................

Patch Set 23:

(4 comments)

File src/mainboard/teleplatforms/D4E4S16P8/ramstage.c:

https://review.coreboot.org/c/coreboot/+/57194/comment/2dad4e96_483fd0e0 
PS21, Line 26: SMBUS_IO_BASE
> Why not `smbus_base()`?

This is ramstage, smbus_base() is romstage. There just isn't a clean way to do anything with SMBus currently.

https://review.coreboot.org/c/coreboot/+/57194/comment/4c2568fc_f87dce0d 
PS21, Line 28: (tmp < 0x20 || tmp > 0x7f)
> 0x7f is DEL, which isn't printable. […]

Not sure if it looks like what you intended?

https://review.coreboot.org/c/coreboot/+/57194/comment/716d83fc_1d900368 
PS21, Line 28: tmp == 0x3f/*?*/
> nit: you can use a character literal in the comparison: […]

Done

https://review.coreboot.org/c/coreboot/+/57194/comment/2f0a639d_355ee818 
PS21, Line 30: memset(serial, 0, sizeof(serial));
             : 				memcpy(serial, ERROR_STRING, sizeof(ERROR_STRING));
             : 				return serial;
> Why not simply `return ERROR_STRING;` instead?

Done