[coreboot-gerrit] [S] Change in coreboot[main]: device: introduce and use dev_get_domain_id

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Fred Reitberger, Jason Glenesk, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Rudolph, Shuo Liu, Tim Chu, Varshit Pandya.

Hello Arthur Heymans, Christian Walter, Fred Reitberger, Jason Glenesk, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Rudolph, Shuo Liu, Tim Chu, Varshit Pandya, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/83644?usp=email

to look at the new patch set (#4).

The following approvals got outdated and were removed:
Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins)

Change subject: device: introduce and use dev_get_domain_id
......................................................................

device: introduce and use dev_get_domain_id

To avoid having constructs like 'dev->path.domain.domain' in the SoC
code, create the 'dev_get_domain_id' helper function that returns the
domain ID of either that device if it's a domain device or the
corresponding domain device's domain ID, and use it in the code.

If this function is called with a device other than PCI or domain type,
it won't have a domain number. In order to not need to call 'die',
'dev_get_domain_id' will print an error and return 0 which is a valid
domain number. In that case, the calling code should be fixed.

Signed-off-by: Felix Held 
Change-Id: I3d79f19846cea49609f848a4c42747ac1052c288
---
M src/device/device_util.c
M src/include/device/device.h
M src/soc/amd/common/block/data_fabric/domain.c
M src/soc/amd/common/block/data_fabric/pci_segment_multi.c
M src/soc/amd/common/block/data_fabric/pci_segment_single.c
M src/soc/amd/common/block/root_complex/root_complex.c
M src/soc/amd/genoa_poc/domain.c
M src/soc/intel/xeon_sp/acpi.c
M src/soc/intel/xeon_sp/chip_common.c
M src/soc/intel/xeon_sp/chip_gen1.c
M src/soc/intel/xeon_sp/chip_gen6.c
M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
12 files changed, 31 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/83644/4