HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )
Change subject: mb/dell: Add Dell Optiplex 790 ......................................................................
Patch Set 60:
(1 comment)
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... File src/mainboard/dell/optiplex_790/romstage.c:
https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... PS60, Line 17: : #include <stdint.h> : #include <string.h> : #include <timestamp.h> : #include <arch/byteorder.h> : #include <arch/io.h> : #include <device/mmio.h> : #include <device/pci_ops.h> : #include <device/pnp_ops.h> : #include <cpu/x86/lapic.h> : #include <console/console.h> : #include <northbridge/intel/sandybridge/sandybridge.h> : #include <northbridge/intel/sandybridge/raminit_native.h> : #include <southbridge/intel/bd82x6x/pch.h> : #include <southbridge/intel/common/gpio.h> include only what you use. please remove unused includes