Attention is currently required from: Matt DeVillier, Sean Rhodes, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80553?usp=email )
Change subject: soc/intel/common/block/dtt: Add ACPI stub for TCPU device
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/dtt/dtt.c:
https://review.coreboot.org/c/coreboot/+/80553/comment/a8d70cb3_7b75761b :
PS3, Line 26:
: /* Skip if DPTF driver in use */
: if (CONFIG(DRIVERS_INTEL_DPTF))
: return;
Done
Hmm, this barely made a difference. Why not put it on top?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80553?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I926d0461e5e0dfaf606102575c2be555a6bfb695
Gerrit-Change-Number: 80553
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sat, 17 Feb 2024 02:11:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment